github-actions[bot] commented on code in PR #39982:
URL: https://github.com/apache/doris/pull/39982#discussion_r1732382987
##########
be/src/pipeline/exec/analytic_sink_operator.cpp:
##########
@@ -231,7 +231,8 @@ Status AnalyticSinkOperatorX::init(const TPlanNode& tnode,
RuntimeState* state)
return Status::OK();
}
-Status AnalyticSinkOperatorX::prepare(RuntimeState* state) {
+Status AnalyticSinkOperatorX::open(RuntimeState* state) {
Review Comment:
warning: method 'open' can be made const
[readability-make-member-function-const]
```suggestion
Status AnalyticSinkOperatorX::open(RuntimeState* state) const {
```
be/src/pipeline/exec/analytic_sink_operator.h:76:
```diff
- Status open(RuntimeState* state) override;
+ Status open(RuntimeState* state) const override;
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.cpp:
##########
@@ -580,8 +580,8 @@ Status HashJoinProbeOperatorX::init(const TPlanNode& tnode,
RuntimeState* state)
return Status::OK();
}
-Status HashJoinProbeOperatorX::prepare(RuntimeState* state) {
-
RETURN_IF_ERROR(JoinProbeOperatorX<HashJoinProbeLocalState>::prepare(state));
+Status HashJoinProbeOperatorX::open(RuntimeState* state) {
Review Comment:
warning: function 'open' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status HashJoinProbeOperatorX::open(RuntimeState* state) {
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/hashjoin_probe_operator.cpp:582:** 97 lines including
whitespace and comments (threshold 80)
```cpp
Status HashJoinProbeOperatorX::open(RuntimeState* state) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
