yiguolei commented on code in PR #39862:
URL: https://github.com/apache/doris/pull/39862#discussion_r1730184290
##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -95,7 +95,9 @@ class ThreadMemTrackerMgr {
void consume(int64_t size, int skip_large_memory_check = 0);
void flush_untracked_mem();
- bool try_reserve(int64_t size);
+ bool try_reserve(int64_t size, std::string& err_msg);
+ bool try_reserve(int64_t size, bool print_err_msg = false);
Review Comment:
Do not need 2 duplicate method. Just return status instead of bool.
And the caller could print the status stack if he want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
