github-actions[bot] commented on code in PR #39649: URL: https://github.com/apache/doris/pull/39649#discussion_r1723305991
########## be/src/olap/rowset/segment_v2/inverted_index_writer.cpp: ########## @@ -342,6 +389,10 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter { Status add_values(const std::string fn, const void* values, size_t count) override { Review Comment: warning: function 'add_values' has cognitive complexity of 55 (threshold 50) [readability-function-cognitive-complexity] ```cpp Status add_values(const std::string fn, const void* values, size_t count) override { ^ ``` <details> <summary>Additional context</summary> **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:390:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if constexpr (field_is_slice_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:391:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_values_field_is_nullptr", ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:391:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_values_field_is_nullptr", ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:393:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_values_index_writer_is_nullptr", ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:393:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_values_index_writer_is_nullptr", ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:395:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (_field == nullptr || _index_writer == nullptr) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:401:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < count; ++i) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:403:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if ((_parser_type == InvertedIndexParserType::PARSER_NONE && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:404:** +1 ```cpp v->get_size() > _ignore_above) || ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:403:** +1 ```cpp if ((_parser_type == InvertedIndexParserType::PARSER_NONE && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:405:** +1 ```cpp (_parser_type != InvertedIndexParserType::PARSER_NONE && v->empty())) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:406:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_null_document()); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:406:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_null_document()); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:407:** +1, nesting level increased to 3 ```cpp } else { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:408:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(new_inverted_index_field(v->get_data(), v->get_size())); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:408:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(new_inverted_index_field(v->get_data(), v->get_size())); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:409:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:409:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:414:** +1, nesting level increased to 1 ```cpp } else if constexpr (field_is_numeric_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:415:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp RETURN_IF_ERROR(add_numeric_values(values, count)); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:415:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp RETURN_IF_ERROR(add_numeric_values(values, count)); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` </details> ########## be/src/olap/rowset/segment_v2/inverted_index_writer.cpp: ########## @@ -369,12 +420,17 @@ Status add_array_values(size_t field_size, const void* value_ptr, const uint8_t* null_map, Review Comment: warning: function 'add_array_values' has cognitive complexity of 119 (threshold 50) [readability-function-cognitive-complexity] ```cpp Status add_array_values(size_t field_size, const void* value_ptr, const uint8_t* null_map, ^ ``` <details> <summary>Additional context</summary> **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:422:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_array_values_count_is_zero", ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:422:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_array_values_count_is_zero", ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:424:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (count == 0) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:429:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if constexpr (field_is_slice_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:430:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:430:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:433:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (_index_writer == nullptr) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:438:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < count; ++i) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:445:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (auto j = start_off; j < start_off + array_elem_size; ++j) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:446:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (null_map[j] == 1) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:450:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if ((_parser_type == InvertedIndexParserType::PARSER_NONE && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:451:** +1 ```cpp v->get_size() > _ignore_above) || ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:450:** +1 ```cpp if ((_parser_type == InvertedIndexParserType::PARSER_NONE && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:452:** +1 ```cpp (_parser_type != InvertedIndexParserType::PARSER_NONE && v->empty())) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:456:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:459:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:459:** +6, including nesting penalty of 5, nesting level increased to 6 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:466:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (st != Status::OK()) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:472:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (_parser_type != InvertedIndexParserType::PARSER_UNKNOWN && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:472:** +1 ```cpp if (_parser_type != InvertedIndexParserType::PARSER_UNKNOWN && ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:479:** +6, including nesting penalty of 5, nesting level increased to 6 ```cpp RETURN_IF_ERROR(create_char_string_reader(char_string_reader)); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:479:** +7, including nesting penalty of 6, nesting level increased to 7 ```cpp RETURN_IF_ERROR(create_char_string_reader(char_string_reader)); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:485:** +1, nesting level increased to 5 ```cpp } else { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:492:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (!_doc->getFields()->empty()) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:494:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:494:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:496:** +1, nesting level increased to 3 ```cpp } else { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:501:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:501:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:507:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (st != Status::OK()) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:514:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_null_document()); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:514:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_null_document()); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:519:** +1, nesting level increased to 1 ```cpp } else if constexpr (field_is_numeric_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:521:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < count; ++i) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:523:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t j = start_off; j < start_off + array_elem_size; ++j) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:524:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (null_map[j] == 1) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:528:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_value(*p)); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:528:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_value(*p)); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` </details> ########## be/src/olap/rowset/segment_v2/inverted_index_writer.cpp: ########## @@ -468,6 +539,11 @@ Status add_array_values(size_t field_size, const CollectionValue* values, Review Comment: warning: function 'add_array_values' has cognitive complexity of 58 (threshold 50) [readability-function-cognitive-complexity] ```cpp Status add_array_values(size_t field_size, const CollectionValue* values, ^ ``` <details> <summary>Additional context</summary> **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:540:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if constexpr (field_is_slice_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:541:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_array_values_field_is_nullptr", ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:541:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp DBUG_EXECUTE_IF("InvertedIndexColumnWriterImpl::add_array_values_field_is_nullptr", ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:543:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (UNLIKELY(config::enable_debug_points)) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:543:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp DBUG_EXECUTE_IF( ^ ``` **be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF' ```cpp if (dp) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:546:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (_field == nullptr || _index_writer == nullptr) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:551:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < count; ++i) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:555:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t j = 0; j < values->length(); ++j) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:558:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!values->is_null_at(j)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:564:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp RETURN_IF_ERROR(new_inverted_index_field(value.c_str(), value.length())); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:564:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(new_inverted_index_field(value.c_str(), value.length())); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:566:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:566:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp RETURN_IF_ERROR(add_document()); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:569:** +1, nesting level increased to 1 ```cpp } else if constexpr (field_is_numeric_type(field_type)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:570:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp for (int i = 0; i < count; ++i) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:573:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t j = 0; j < values->length(); ++j) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:575:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (values->is_null_at(j)) { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:577:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:578:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp RETURN_IF_ERROR(add_value(*p)); ^ ``` **be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR' ```cpp do { \ ^ ``` **be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:578:** +6, including nesting penalty of 5, nesting level increased to 6 ```cpp RETURN_IF_ERROR(add_value(*p)); ^ ``` **be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR' ```cpp if (UNLIKELY(!_status_.ok())) { \ ^ ``` </details> ########## be/src/olap/compaction.cpp: ########## @@ -796,108 +831,162 @@ Status Compaction::do_inverted_index_compaction() { return Status::OK(); } -void Compaction::construct_skip_inverted_index(RowsetWriterContext& ctx) { +Status Compaction::construct_skip_inverted_index(RowsetWriterContext& ctx) { Review Comment: warning: function 'construct_skip_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp Status Compaction::construct_skip_inverted_index(RowsetWriterContext& ctx) { ^ ``` <details> <summary>Additional context</summary> **be/src/olap/compaction.cpp:833:** 156 lines including whitespace and comments (threshold 80) ```cpp Status Compaction::construct_skip_inverted_index(RowsetWriterContext& ctx) { ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org