xinyiZzz commented on pull request #8745: URL: https://github.com/apache/incubator-doris/pull/8745#issuecomment-1085379967
The strategy of RuntimeFilter should be placed in `RuntimeFilterGenerator`, not `Planner`, which will destroy the previous structure. Three suggestions~: 1. Before `generateFilters`, use a Map to store whether all Tuples of PlanTree have conjuncts; 2. This strategy should be placed in `RuntimeFilter create` to filter `srcExpr`, similar to the one selected in the picture; the `removeUselessRuntimeFilters` Func is no longer needed; 3. Modify the name of `ENABLE_STAR_SCHEMA_RUNTIME_FILTER_POLICY`. This policy is not directly related to star schema, for example: `ENABLE_REMOVE_NO_CONJUNCTS_RUNTIME_FILTER`. Or add enough comments to explain that this strategy is beneficial in most star schemas, otherwise it is misleading; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
