zhannngchen opened a new pull request #8623: URL: https://github.com/apache/incubator-doris/pull/8623
# Proposed changes Issue Number: open #7678 ## Problem Summary: Support min_by/max_by on vectorized engine. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (Yes) 3. Has document been added or modified: (Yes) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments 1. This is an initial patch, I will add the document later. 2. For now, aggregate functions only supports 1 intermediate type, but min_by/max_by needs 2 type information, I've did a tricky work-around int this initial patch, but we need to discuss that do we really need to change the intermediate type to an intermediate type list? @morningman @dataroaring. Another solution is to serialize the type information in the intermediate data. 3. To support these 2 functions in the non-vectorized code needs to pay much more efforts, we may need to do some refactor. Do we need to support this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
