yangzhg commented on a change in pull request #8545: URL: https://github.com/apache/incubator-doris/pull/8545#discussion_r830721687
########## File path: thirdparty/vars.sh ########## @@ -52,6 +52,12 @@ export REPOSITORY_URL=https://doris-thirdparty-repo.bj.bcebos.com/thirdparty # of all thirdparties ##################################################### +# libbacktrace +LIBBACKTRACE_DOWNLOAD="https://github.com/Doris-Extras/libbacktrace/archive/refs/tags/libbacktrace-1.0.zip"; Review comment: Why not use the origin repo ? The license of the original repository does not allow changes to the source code, if you fork to a third-party repository, it is likely that there will be occasional changes later, I think it is more appropriate to use the original repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
