amorynan commented on code in PR #38384:
URL: https://github.com/apache/doris/pull/38384#discussion_r1695274033
##########
be/src/vec/functions/array/function_array_enumerate_uniq.cpp:
##########
@@ -95,15 +95,13 @@ class FunctionArrayEnumerateUniq : public IFunction {
"The {} -th argument for function: {} .must be an
array but it type is {}",
i, get_name(), arguments[i]->get_name());
}
- if (i == 0) {
- is_nested_nullable =
array_type->get_nested_type()->is_nullable();
- }
+ is_nested_nullable = is_nested_nullable |
array_type->get_nested_type()->is_nullable();
Review Comment:
``` || ``` and ``` | ``` all make the res right, I intended to use bit
operation, but ``` || ``` can short-circuit phrase, I will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
