Re: [PR] [Fix](nereids) change char(0) to char(1), varchar(0) to varchar(65533) when create table [doris]

[via GitHub]

morrySnow commented on code in PR #38427:
URL: https://github.com/apache/doris/pull/38427#discussion_r1695154978


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java:
##########
@@ -187,10 +188,10 @@ private DataType updateCharacterTypeLength(DataType 
dataType) {
                     .collect(ImmutableList.toImmutableList());
             return new StructType(structFields);
         } else {
-            if (dataType.isStringLikeType()) {
-                if (dataType instanceof CharType && ((CharType) 
dataType).getLen() == -1) {
+            if (dataType.isStringLikeType() && !((CharacterType) 
dataType).isLengthSet()) {
+                if (dataType instanceof CharType) {
                     return new CharType(1);

Review Comment:
   why char(0) to char(1), follow legacy planner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org