github-actions[bot] commented on code in PR #37293:
URL: https://github.com/apache/doris/pull/37293#discussion_r1694756329
##########
cloud/src/meta-service/meta_service_job.cpp:
##########
@@ -49,6 +49,29 @@ namespace doris::cloud {
static constexpr int COMPACTION_DELETE_BITMAP_LOCK_ID = -1;
static constexpr int SCHEMA_CHANGE_DELETE_BITMAP_LOCK_ID = -2;
+// check compaction input_versions are valid during schema change.
+// If the schema change job doesnt have alter version, it dont need to check
+// because the schema change job is come from old version BE.
+// we will check they in prepare compaction and commit compaction.
+// 1. When if base compaction, we need to guarantee the end version
+// is less than or equal to alter_version.
+// 2. When if cu compaction, we need to guarantee the start version
+// is large than alter_version.
+bool check_compaction_input_verions(const TabletCompactionJobPB& compaction,
+ const TabletJobInfoPB& job_pb) {
+ if (!job_pb.has_schema_change() ||
!job_pb.schema_change().has_alter_version()) return true;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (!job_pb.has_schema_change() ||
!job_pb.schema_change().has_alter_version()) { return true;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
