gavinchou commented on code in PR #37293:
URL: https://github.com/apache/doris/pull/37293#discussion_r1694300002
##########
fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java:
##########
@@ -124,6 +124,15 @@ protected void onCancel() {
try {
((CloudInternalCatalog) Env.getCurrentInternalCatalog())
.dropMaterializedIndex(tableId, rollupIndexList, false);
+ for (Map.Entry<Long, Map<Long, Long>> partitionEntry :
partitionIdToBaseRollupTabletIdMap.entrySet()) {
+ Long partitionId = partitionEntry.getKey();
+ Map<Long, Long> rollupTabletIdToBaseTabletId =
partitionEntry.getValue();
+ for (Map.Entry<Long, Long> tabletEntry :
rollupTabletIdToBaseTabletId.entrySet()) {
+ Long baseTabletId = tabletEntry.getValue();
+ ((CloudInternalCatalog)
Env.getCurrentInternalCatalog())
+ .removeSchemaChangeJob(dbId, tableId, baseIndexId,
partitionId, baseTabletId);
+ }
+ }
Review Comment:
log here:
* which table/index has been processed (id name etc.)
* how many talbets have been processed here.
and, what if it tries to abort the same tablet job multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
