xiaokang commented on code in PR #38220:
URL: https://github.com/apache/doris/pull/38220#discussion_r1694235068
##########
be/src/cloud/cloud_cumulative_compaction_policy.h:
##########
@@ -34,6 +34,8 @@ namespace doris {
class Tablet;
struct Version;
+static constexpr int MAX_COMPACT_ROWSET_COUNT = 10000;
Review Comment:
It's better to add a be config.
##########
be/src/olap/compaction.cpp:
##########
@@ -1223,8 +1223,10 @@ Status
CloudCompactionMixin::construct_output_rowset_writer(RowsetWriterContext&
ctx.write_type = DataWriteType::TYPE_COMPACTION;
auto compaction_policy = _tablet->tablet_meta()->compaction_policy();
- ctx.compaction_level =
-
_engine.cumu_compaction_policy(compaction_policy)->new_compaction_level(_input_rowsets);
+ if (_tablet->tablet_meta()->time_series_compaction_level_threshold() >= 2)
{
+ ctx.compaction_level =
_engine.cumu_compaction_policy(compaction_policy)
Review Comment:
What problem this code try to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
