liugddx commented on code in PR #38215:
URL: https://github.com/apache/doris/pull/38215#discussion_r1691371195
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -115,10 +117,24 @@ void DataTypeDateTimeV2SerDe::write_column_to_arrow(const
IColumn& column, const
if (scale > 3) {
uint32_t microsecond = datetime_val.microsecond();
timestamp = (timestamp * 1000000) + microsecond;
+ timestamp -=
std::chrono::duration_cast<std::chrono::microseconds>(
+ cctz::convert(cctz::civil_second(1970, 1,
1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
} else if (scale > 0) {
uint32_t millisecond = datetime_val.microsecond() / 1000;
timestamp = (timestamp * 1000) + millisecond;
+ timestamp -=
std::chrono::duration_cast<std::chrono::milliseconds>(
+ cctz::convert(cctz::civil_second(1970, 1,
1, 0, 0, 0), ctz)
+ .time_since_epoch())
+ .count();
+ } else if (scale == 0) {
+ timestamp -= std::chrono::duration_cast<std::chrono::seconds>(
Review Comment:
> Should the logic here be removed? It should only require modifying the
scale of the TypeDescriptor.
Already Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
