yiguolei commented on code in PR #38238: URL: https://github.com/apache/doris/pull/38238#discussion_r1689879975
########## be/src/io/fs/local_file_reader.h: ########## @@ -26,6 +26,20 @@ #include "io/fs/path.h" #include "util/slice.h" +namespace doris { + +struct StorePath; +struct DataDirInfo; + +// data dir in be config, currently include storage dir and spill disk dir +extern std::vector<DataDirInfo> be_config_data_dir_list; Review Comment: avoid using global variable because it is related with compile component . Move it to LocalFileReader as a static variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org