wangbo commented on code in PR #38238: URL: https://github.com/apache/doris/pull/38238#discussion_r1689540355
########## be/src/olap/storage_engine.cpp: ########## @@ -182,6 +184,37 @@ void CompactionSubmitRegistry::jsonfy_compaction_status(std::string* result) { *result = std::string(str_buf.GetString()); } +void BaseStorageEngine::init_data_dir(const std::vector<StorePath>& store_paths, + const std::vector<StorePath>& spill_store_paths) { + for (int i = 0; i < store_paths.size(); i++) { + DataDirInfo data_dir_info; + data_dir_info.path = store_paths[i].path; + data_dir_info.storage_medium = store_paths[i].storage_medium; + data_dir_info.data_dir_type = DataDirType::OLAP_DATA_DIR; + BaseStorageEngine::data_dir_list.push_back(data_dir_info); + } + + for (int i = 0; i < spill_store_paths.size(); i++) { + DataDirInfo data_dir_info; Review Comment: 感觉store path有点重啊,不需要那么多信息,有个路径和类型就行 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org