xinyiZzz commented on pull request #8476: URL: https://github.com/apache/incubator-doris/pull/8476#issuecomment-1070230507
> The patch is very uncomfortable for reviewer due to many files it changed. I looked at about 100 files and added a few comment. > > You'd better split changes into small parts. e.g. 1. implement new memory tracker by hooking new, delete but not enable; 2. enable new memory tracker by removing old usage; 3. handle null pointer for old fasion allocate 4. add memory tracker for untracked memory usage; > > This way, we can review the 2nd patch quickly and review others carefully. The majority can be put into to the 2nd part, right? thx for your suggestion, I will pay attention to control the size of pr later, I consider moving some minor changes to the pr behind. In fact, I have split a big feature into three, this is the second one... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
