spaces-X commented on a change in pull request #8234:
URL: https://github.com/apache/incubator-doris/pull/8234#discussion_r824717556
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
##########
@@ -386,25 +386,18 @@ public void analyze(Analyzer analyzer) throws
UserException {
}
}
- if (columnDef.getType().isHllType()) {
- hasHll = true;
- }
-
- if (columnDef.getAggregateType() == AggregateType.BITMAP_UNION) {
- hasBitmap = columnDef.getType().isBitmapType();
+ if (columnDef.getType().isObjectStored()) {
+ hasObjectStored = true;
+ objectStoredColumn = columnDef.getName();
}
if (!columnSet.add(columnDef.getName())) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_DUP_FIELDNAME,
columnDef.getName());
}
}
- if (hasHll && keysDesc.getKeysType() != KeysType.AGG_KEYS) {
- throw new AnalysisException("HLL must be used in AGG_KEYS");
- }
-
- if (hasBitmap && keysDesc.getKeysType() != KeysType.AGG_KEYS) {
- throw new AnalysisException("BITMAP_UNION must be used in
AGG_KEYS");
+ if (hasObjectStored && keysDesc.getKeysType() != KeysType.AGG_KEYS) {
+ throw new AnalysisException("object stored column must be used in
AGG_KEYS table, object stored column:" + objectStoredColumn);
Review comment:
ok i will remove the object stored key words just keep the column name
in message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
