[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8373: [Refactor] to_bitmap(-1) return NULL instead of return parse failed error_message

[GitBox]

BiteTheDDDDt commented on a change in pull request #8373:
URL: https://github.com/apache/incubator-doris/pull/8373#discussion_r823490573



##########
File path: be/src/vec/sink/vtablet_sink.cpp
##########
@@ -174,7 +174,7 @@ Status VOlapTableSink::_validate_data(RuntimeState* state, 
vectorized::Block* bl
                 
block->get_by_position(i).column->convert_to_full_column_if_const();
         const auto& column = block->get_by_position(i).column;
 
-        if (desc->is_nullable() && desc->type() == TYPE_OBJECT) {
+        if (desc->is_nullable() && desc->type() == TYPE_OBJECT && 
column->is_nullable()) {

Review comment:
       desc->is_nullable() can remove




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org