This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new cb2f95ee2ed [fix](Nereids) fix fe fold constant failed when using like
function (#37864)
cb2f95ee2ed is described below
commit cb2f95ee2ed5c1e7bfa0fef7eb04759094067661
Author: LiBinfeng <[email protected]>
AuthorDate: Tue Jul 16 16:02:29 2024 +0800
[fix](Nereids) fix fe fold constant failed when using like function (#37864)
cherry-pick: #37616
---
.../nereids/rules/expression/rules/FoldConstantRuleOnFE.java | 6 ------
.../expression/fold_constant/fold_constant_by_fe.groovy | 11 ++++++++++-
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java
index cf3d1a88d8c..31ed154da3d 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java
@@ -43,7 +43,6 @@ import org.apache.doris.nereids.trees.expressions.InPredicate;
import org.apache.doris.nereids.trees.expressions.IsNull;
import org.apache.doris.nereids.trees.expressions.LessThan;
import org.apache.doris.nereids.trees.expressions.LessThanEqual;
-import org.apache.doris.nereids.trees.expressions.Like;
import org.apache.doris.nereids.trees.expressions.Not;
import org.apache.doris.nereids.trees.expressions.NullSafeEqual;
import org.apache.doris.nereids.trees.expressions.Or;
@@ -403,11 +402,6 @@ public class FoldConstantRuleOnFE extends
AbstractExpressionRewriteRule
}
}
- @Override
- public Expression visitLike(Like like, ExpressionRewriteContext context) {
- return like;
- }
-
@Override
public Expression visitCast(Cast cast, ExpressionRewriteContext context) {
cast = rewriteChildren(cast, context);
diff --git
a/regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_by_fe.groovy
b/regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_by_fe.groovy
index a706ee9abf9..cc63662657c 100644
---
a/regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_by_fe.groovy
+++
b/regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_by_fe.groovy
@@ -19,6 +19,7 @@ suite("test_fold_constant_by_fe") {
sql 'set enable_nereids_planner=true'
sql 'set enable_fallback_to_original_planner=false'
sql 'set enable_fold_nondeterministic_fn=true'
+ sql 'set enable_fold_constant_by_be=false'
def results = sql 'select uuid(), uuid()'
assertFalse(Objects.equals(results[0][0], results[0][1]))
@@ -154,4 +155,12 @@ suite("test_fold_constant_by_fe") {
res = res.split('VUNION')[1]
assertFalse(res.contains("unix"))
}
-}
\ No newline at end of file
+
+ // test null like string cause of fe need to fold constant like that to
enable not null derive
+ res = sql """explain select null like '%123%'"""
+ assertFalse(res.contains("like"))
+ // now fe fold constant still can not deal with this case
+ res = sql """explain select "12" like '%123%'"""
+ assertTrue(res.contains("like"))
+
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
