zbtzbtzbt commented on a change in pull request #8318:
URL: https://github.com/apache/incubator-doris/pull/8318#discussion_r822255678
##########
File path: be/src/runtime/string_value.h
##########
@@ -60,10 +105,36 @@ struct StringValue {
// this < other: -1
// this == other: 0
// this > other: 1
- int compare(const StringValue& other) const;
+ int compare(const StringValue& other) const {
Review comment:
small function add key word `inline`，the same for following `eq`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
