ByteYue commented on code in PR #37537:
URL: https://github.com/apache/doris/pull/37537#discussion_r1676845267
##########
cloud/src/meta-service/meta_service_resource.cpp:
##########
@@ -509,6 +509,80 @@ static void set_default_vault_log_helper(const
InstanceInfoPB& instance,
LOG(INFO) << vault_msg;
}
+static int alter_storage_vault(InstanceInfoPB& instance,
std::unique_ptr<Transaction> txn,
+ const StorageVaultPB& vault, MetaServiceCode&
code,
+ std::string& msg) {
+ if (!vault.has_obj_info()) {
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ std::stringstream ss;
+ ss << "Only s3 vault can be altered";
Review Comment:
Currently i'm not sure which property of hdfs vault can be altered. As the
pr title says, this pr is for `S3 Vault`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
