yiguolei commented on code in PR #37559: URL: https://github.com/apache/doris/pull/37559#discussion_r1675404264
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueryQueue.java: ########## @@ -126,30 +138,47 @@ public QueueToken getToken() throws UserException { } } - public void releaseAndNotify(QueueToken releaseToken) { + public void releaseAndNotify(QueueToken releaseToken, AdmissionControl ac) { Review Comment: 如果 107 行和 141 行都依赖这个adminsion control, 那么就把这个东东作为queue的一个属性吧,就不用四处传递获取了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org