xiaokang commented on code in PR #37180:
URL: https://github.com/apache/doris/pull/37180#discussion_r1667882495
##########
be/src/exec/es/es_scan_reader.cpp:
##########
@@ -155,7 +183,9 @@ Status ESScanReader::get_next(bool* scan_eos,
std::unique_ptr<ScrollParser>& scr
if (_exactly_once) {
return Status::OK();
}
- RETURN_IF_ERROR(_network_client.init(_next_scroll_url));
+ // we do not enable set_fail_on_error for ES http request to get more
detail error messages
+ bool set_fail_on_error = false;
+ RETURN_IF_ERROR(_network_client.init(_next_scroll_url,
set_fail_on_error));
Review Comment:
Why change error handling behavior here?
##########
be/src/exec/es/es_scan_reader.cpp:
##########
@@ -211,7 +243,9 @@ Status ESScanReader::close() {
}
std::string scratch_target = _target + REQUEST_SEARCH_SCROLL_PATH;
- RETURN_IF_ERROR(_network_client.init(scratch_target));
+ // we do not enable set_fail_on_error for ES http request to get more
detail error messages
+ bool set_fail_on_error = false;
+ RETURN_IF_ERROR(_network_client.init(scratch_target, set_fail_on_error));
Review Comment:
Why change error handling behavior here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
