github-actions[bot] commented on code in PR #37415:
URL: https://github.com/apache/doris/pull/37415#discussion_r1667876925


##########
be/src/olap/rowset/rowset.h:
##########
@@ -164,6 +164,7 @@ class Rowset : public std::enable_shared_from_this<Rowset> {
     int64_t newest_write_timestamp() const { return 
rowset_meta()->newest_write_timestamp(); }
     bool is_segments_overlapping() const { return 
rowset_meta()->is_segments_overlapping(); }
     KeysType keys_type() { return _schema->keys_type(); }
+    RowsetStatePB rowset_meta_state() const { return 
rowset_meta()->rowset_state(); }

Review Comment:
   warning: function 'rowset_meta_state' should be marked [[nodiscard]] 
[modernize-use-nodiscard]
   
   ```suggestion
   ; }[[nodiscard]] 
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to