github-actions[bot] commented on code in PR #37383:
URL: https://github.com/apache/doris/pull/37383#discussion_r1667600005
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -402,7 +402,7 @@ void
RoutineLoadTaskExecutor::exec_task(std::shared_ptr<StreamLoadContext> ctx,
}
// need memory order
multi_table_pipe->handle_consume_finished();
- HANDLE_ERROR(kafka_pipe->finish(), "finish multi table task failed");
+ HANDLE_MULTI_TABLE_ERROR(kafka_pipe->finish(), "finish multi table
task failed");
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
HANDLE_MULTI_TABLE_ERROR(kafka_pipe->finish(), "finish multi table
task failed");
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/routine_load/routine_load_task_executor.cpp:322:** expanded
from macro 'HANDLE_MULTI_TABLE_ERROR'
```cpp
if (UNLIKELY(!_status_.ok() && !_status_.is<PUBLISH_TIMEOUT>())) { \
^
```
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
