This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0babde17bf2 [chore](Regression) Remove useless get provider code in
regression framework (#37000)
0babde17bf2 is described below
commit 0babde17bf248dedff7a9cc7f61dc43506322187
Author: AlexYue <[email protected]>
AuthorDate: Mon Jul 1 09:59:48 2024 +0800
[chore](Regression) Remove useless get provider code in regression
framework (#37000)
The following get provider and check logic code is useless.
---
.../main/groovy/org/apache/doris/regression/Config.groovy | 13 +------------
.../groovy/org/apache/doris/regression/suite/Suite.groovy | 15 ---------------
2 files changed, 1 insertion(+), 27 deletions(-)
diff --git
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy
index 008962ee544..c6711184c01 100644
---
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy
+++
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy
@@ -564,16 +564,6 @@ class Config {
return config
}
- static String getProvider(String endpoint) {
- def providers = ["cos", "oss", "s3", "obs", "bos"]
- for (final def provider in providers) {
- if (endpoint.containsIgnoreCase(provider)) {
- return provider
- }
- }
- return ""
- }
-
static void checkCloudSmokeEnv(Properties properties) {
// external stage obj info
String s3Endpoint = properties.getOrDefault("s3Endpoint", "")
@@ -589,8 +579,7 @@ class Config {
s3EndpointConf:s3Endpoint,
s3BucketConf:s3BucketName,
s3AKConf:s3AK,
- s3SKConf:s3SK,
- s3ProviderConf:getProvider(s3Endpoint)
+ s3SKConf:s3SK
]
for (final def item in items) {
if (item.value == null || item.value.isEmpty()) {
diff --git
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy
index b3a2e958ff0..3397ab4ccfc 100644
---
a/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy
+++
b/regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy
@@ -894,21 +894,6 @@ class Suite implements GroovyInterceptable {
return;
}
- String getProvider() {
- String s3Endpoint = context.config.otherConfigs.get("s3Endpoint")
- return getProvider(s3Endpoint)
- }
-
- String getProvider(String endpoint) {
- def providers = ["cos", "oss", "s3", "obs", "bos"]
- for (final def provider in providers) {
- if (endpoint.containsIgnoreCase(provider)) {
- return provider
- }
- }
- return ""
- }
-
int getTotalLine(String filePath) {
def file = new File(filePath)
int lines = 0;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
