This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 1cbc322d0c548d04cde2dd52ed7a462072a36af4
Author: zy-kkk <zhongy...@gmail.com>
AuthorDate: Fri Jun 28 20:13:34 2024 +0800

    [improvement](jdbc catalog) Modify the maximum number of connections in the 
connection pool to 30 by default (#36720)
    
    In many cases, we found that users would use JDBC Catalog to perform a
    large number of queries, which resulted in the maximum of 10 connections
    being insufficient, so I adjusted it to 30, which covered most needs.
---
 .../src/main/java/org/apache/doris/jdbc/JdbcDataSourceConfig.java     | 2 +-
 fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java   | 2 +-
 .../src/test/java/org/apache/doris/catalog/JdbcResourceTest.java      | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSourceConfig.java
 
b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSourceConfig.java
index 5fdbc211ab0..a99377add25 100644
--- 
a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSourceConfig.java
+++ 
b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSourceConfig.java
@@ -31,7 +31,7 @@ public class JdbcDataSourceConfig {
     private TJdbcOperation op;
     private TOdbcTableType tableType;
     private int connectionPoolMinSize = 1;
-    private int connectionPoolMaxSize = 10;
+    private int connectionPoolMaxSize = 30;
     private int connectionPoolMaxWaitTime = 5000;
     private int connectionPoolMaxLifeTime = 1800000;
     private boolean connectionPoolKeepAlive = false;
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java 
b/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
index 3878500f917..1db801b024a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
@@ -140,7 +140,7 @@ public class JdbcResource extends Resource {
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(INCLUDE_DATABASE_LIST, "");
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(EXCLUDE_DATABASE_LIST, "");
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_MIN_SIZE, "1");
-        OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_MAX_SIZE, "10");
+        OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_MAX_SIZE, "30");
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_MAX_LIFE_TIME, 
"1800000");
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_MAX_WAIT_TIME, 
"5000");
         OPTIONAL_PROPERTIES_DEFAULT_VALUE.put(CONNECTION_POOL_KEEP_ALIVE, 
"false");
diff --git 
a/fe/fe-core/src/test/java/org/apache/doris/catalog/JdbcResourceTest.java 
b/fe/fe-core/src/test/java/org/apache/doris/catalog/JdbcResourceTest.java
index 8e004d4b236..81c2157686a 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/catalog/JdbcResourceTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/catalog/JdbcResourceTest.java
@@ -87,7 +87,7 @@ public class JdbcResourceTest {
         // Verify the default properties were applied during the replay
         Map<String, String> properties = jdbcResource.getCopiedProperties();
         Assert.assertEquals("1", properties.get("connection_pool_min_size"));
-        Assert.assertEquals("10", properties.get("connection_pool_max_size"));
+        Assert.assertEquals("30", properties.get("connection_pool_max_size"));
         Assert.assertEquals("1800000", 
properties.get("connection_pool_max_life_time"));
         Assert.assertEquals("5000", 
properties.get("connection_pool_max_wait_time"));
         Assert.assertEquals("false", 
properties.get("connection_pool_keep_alive"));
@@ -110,7 +110,7 @@ public class JdbcResourceTest {
         // Verify the default properties were applied during the replay
         Map<String, String> properties = 
replayedResource.getCopiedProperties();
         Assert.assertEquals("1", properties.get("connection_pool_min_size"));
-        Assert.assertEquals("10", properties.get("connection_pool_max_size"));
+        Assert.assertEquals("30", properties.get("connection_pool_max_size"));
         Assert.assertEquals("1800000", 
properties.get("connection_pool_max_life_time"));
         Assert.assertEquals("5000", 
properties.get("connection_pool_max_wait_time"));
         Assert.assertEquals("false", 
properties.get("connection_pool_keep_alive"));


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to