This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push: new f4a617a5927 [fix](fe ut) fix unstable SystemInfoServiceTest #36893 (#36975) f4a617a5927 is described below commit f4a617a5927f777195ac9352e49c2f2345910175 Author: yujun <yu.jun.re...@gmail.com> AuthorDate: Fri Jun 28 16:30:03 2024 +0800 [fix](fe ut) fix unstable SystemInfoServiceTest #36893 (#36975) cherry pick from #36893 --- .../org/apache/doris/system/SystemInfoServiceTest.java | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fe/fe-core/src/test/java/org/apache/doris/system/SystemInfoServiceTest.java b/fe/fe-core/src/test/java/org/apache/doris/system/SystemInfoServiceTest.java index 9578ed1c7ff..6092a50330b 100644 --- a/fe/fe-core/src/test/java/org/apache/doris/system/SystemInfoServiceTest.java +++ b/fe/fe-core/src/test/java/org/apache/doris/system/SystemInfoServiceTest.java @@ -46,6 +46,8 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; public class SystemInfoServiceTest { private SystemInfoService infoService; @@ -403,7 +405,7 @@ public class SystemInfoServiceTest { ReplicaAllocation replicaAlloc = ReplicaAllocation.DEFAULT_ALLOCATION; // also check if the random selection logic can evenly distribute the replica. Map<Long, Integer> beCounterMap = Maps.newHashMap(); - for (int i = 0; i < 10000; ++i) { + for (int i = 0; i < 30000; ++i) { Pair<Map<Tag, List<Long>>, TStorageMedium> ret = infoService.selectBackendIdsForReplicaCreation(replicaAlloc, Maps.newHashMap(), TStorageMedium.HDD, false, false); Map<Tag, List<Long>> res = ret.first; @@ -412,11 +414,16 @@ public class SystemInfoServiceTest { beCounterMap.put(beId, beCounterMap.getOrDefault(beId, 0) + 1); } } + Set<Long> expectBackendIds = infoService.getMixBackends().stream() + .filter(Backend::isAlive).map(Backend::getId) + .collect(Collectors.toSet()); + Assert.assertEquals(expectBackendIds, beCounterMap.keySet().stream().collect(Collectors.toSet())); List<Integer> list = Lists.newArrayList(beCounterMap.values()); Collections.sort(list); - int diff = list.get(list.size() - 1) - list.get(0); - // The max replica num and min replica num's diff is less than 5%. - Assert.assertTrue((diff * 1.0 / list.get(0)) < 0.05); + int max = list.get(list.size() - 1); + int diff = max - list.get(0); + // The max replica num and min replica num's diff is less than 30%. + Assert.assertTrue((diff * 1.0 / max) < 0.3); } private void addDisk(Backend be, String path, TStorageMedium medium, long totalB, long availB) { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org