This is an automated email from the ASF dual-hosted git repository.
jianliangqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ab18c0fb154 [Fix](inverted index) try not to delete entries in
DorisCompoundReader::close (#36420)
ab18c0fb154 is described below
commit ab18c0fb1544b21bb874b0d943edb5b3a6d81eff
Author: airborne12 <[email protected]>
AuthorDate: Tue Jun 18 10:44:47 2024 +0800
[Fix](inverted index) try not to delete entries in
DorisCompoundReader::close (#36420)
Deleting entries in DorisCompoundReader::close() might lead to a
coredump in certain cases, especially with problematic inverted index
files.
---
be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp
b/be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp
index 85134f73108..5e6d8747a2d 100644
--- a/be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp
+++ b/be/src/olap/rowset/segment_v2/inverted_index_compound_reader.cpp
@@ -203,6 +203,7 @@ DorisCompoundReader::~DorisCompoundReader() {
LOG(ERROR) << "DorisCompoundReader finalize error:" << err.what();
}
}
+ _CLDELETE(entries)
}
const char* DorisCompoundReader::getClassName() {
@@ -294,7 +295,6 @@ void DorisCompoundReader::close() {
}
if (entries != nullptr) {
entries->clear();
- _CLDELETE(entries)
}
if (ram_dir) {
ram_dir->close();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
