This is an automated email from the ASF dual-hosted git repository.
jacktengg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 781c9508cf3 [improvement](chore) remove unused code of RuntimeState
(#35656)
781c9508cf3 is described below
commit 781c9508cf3449a6f01b3ffe79cccb10bfa63c59
Author: TengJianPing <18241664+jackte...@users.noreply.github.com>
AuthorDate: Fri Jun 14 23:40:19 2024 +0800
[improvement](chore) remove unused code of RuntimeState (#35656)
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
---
be/src/runtime/runtime_state.cpp | 6 ------
be/src/runtime/runtime_state.h | 7 -------
2 files changed, 13 deletions(-)
diff --git a/be/src/runtime/runtime_state.cpp b/be/src/runtime/runtime_state.cpp
index 17349c93079..6626ada034c 100644
--- a/be/src/runtime/runtime_state.cpp
+++ b/be/src/runtime/runtime_state.cpp
@@ -55,7 +55,6 @@ RuntimeState::RuntimeState(const TPlanFragmentExecParams&
fragment_exec_params,
: _profile("Fragment " +
print_id(fragment_exec_params.fragment_instance_id)),
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_query_id(fragment_exec_params.query_id),
_per_fragment_instance_idx(0),
@@ -101,7 +100,6 @@ RuntimeState::RuntimeState(const TUniqueId& instance_id,
const TUniqueId& query_
: _profile("Fragment " + print_id(instance_id)),
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_query_id(query_id),
_fragment_id(fragment_id),
@@ -138,7 +136,6 @@
RuntimeState::RuntimeState(pipeline::PipelineFragmentContext*, const TUniqueId&
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
_runtime_filter_mgr(nullptr),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_query_id(query_id),
_fragment_id(fragment_id),
@@ -171,7 +168,6 @@ RuntimeState::RuntimeState(const TUniqueId& query_id,
int32_t fragment_id,
: _profile("PipelineX " + std::to_string(fragment_id)),
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_query_id(query_id),
_fragment_id(fragment_id),
@@ -205,7 +201,6 @@ RuntimeState::RuntimeState(const TQueryGlobals&
query_globals)
: _profile("<unnamed>"),
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_per_fragment_instance_idx(0) {
_query_options.batch_size = DEFAULT_BATCH_SIZE;
@@ -239,7 +234,6 @@ RuntimeState::RuntimeState()
: _profile("<unnamed>"),
_load_channel_profile("<unnamed>"),
_obj_pool(new ObjectPool()),
- _data_stream_recvrs_pool(new ObjectPool()),
_unreported_error_idx(0),
_per_fragment_instance_idx(0) {
_query_options.batch_size = DEFAULT_BATCH_SIZE;
diff --git a/be/src/runtime/runtime_state.h b/be/src/runtime/runtime_state.h
index d61bca2182e..760398fcb92 100644
--- a/be/src/runtime/runtime_state.h
+++ b/be/src/runtime/runtime_state.h
@@ -643,13 +643,6 @@ private:
// owned by PipelineFragmentContext
RuntimeFilterMgr* _pipeline_x_runtime_filter_mgr = nullptr;
- // Data stream receivers created by a plan fragment are gathered here to
make sure
- // they are destroyed before _obj_pool (class members are destroyed in
reverse order).
- // Receivers depend on the descriptor table and we need to guarantee that
their control
- // blocks are removed from the data stream manager before the objects in
the
- // descriptor table are destroyed.
- std::unique_ptr<ObjectPool> _data_stream_recvrs_pool;
-
// Lock protecting _error_log and _unreported_error_idx
std::mutex _error_log_lock;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
