morningman commented on pull request #8041: URL: https://github.com/apache/incubator-doris/pull/8041#issuecomment-1047439684
I have several questions and suggestions as follows: 1. this feature is directly user-oriented, we need to have more detailed documentation to explain how to use this feature, applicable scenarios, etc. Otherwise, it is difficult for other users to understand the meaning of `Random` and `single_tablet_load_per_sink`. 2. It is recommended NOT to use those `RANDOM classes` directly which has been deprecated before. We do not strictly check whether old versions of random tables still exist in the current version. Using it directly will cause metadata problems. 3. `single_tablet_load_per_sink` is too close to the specific implementation, suggest: `load_to_single_tablet` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
