HappenLee commented on a change in pull request #8119:
URL: https://github.com/apache/incubator-doris/pull/8119#discussion_r810656345
##########
File path: be/src/vec/exec/vset_operation_node.h
##########
@@ -81,6 +81,7 @@ class VSetOperationNode : public ExecNode {
//record insert column id during probe
std::vector<uint16_t> _probe_column_inserted_id;
+ Block _build_block;
Review comment:
do the same opt in vset_operation_node, only one block cause mem problem?
##########
File path: be/src/vec/exec/join/vhash_join_node.h
##########
@@ -203,6 +203,7 @@ class HashJoinNode : public ::doris::ExecNode {
HashTableVariants _hash_table_variants;
AcquireList<Block> _acquire_list;
+ std::vector<Block> _build_block;
Review comment:
_build_blocks
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -184,19 +179,21 @@ struct ProcessHashTableProbe {
KeyGetter key_getter(_probe_raw_ptrs, _join_node->_probe_key_sz,
nullptr);
- std::vector<uint32_t> items_counts(_probe_rows);
+ uint32_t items_counts[_probe_rows];
auto& mcol = mutable_block.mutable_columns();
int current_offset = 0;
+ //build_block_index size may be largger than _batch_size, 100 is
safety.
+ int build_block_row_num[_batch_size + 100];
Review comment:
it's dangerous to have a pre safety set for noknown data, may should use
vector.
##########
File path: be/src/vec/exec/join/join_op.h
##########
@@ -26,15 +26,16 @@ namespace doris::vectorized {
struct RowRef {
using SizeT = uint32_t; /// Do not use size_t cause of memory economy
- const Block* block = nullptr;
+ // const Block* block = nullptr;
Review comment:
directly delete the code
##########
File path: be/src/vec/exec/join/vhash_join_node.cpp
##########
@@ -184,19 +179,21 @@ struct ProcessHashTableProbe {
KeyGetter key_getter(_probe_raw_ptrs, _join_node->_probe_key_sz,
nullptr);
- std::vector<uint32_t> items_counts(_probe_rows);
+ uint32_t items_counts[_probe_rows];
Review comment:
use vector to init the uint32_t to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
