morrySnow commented on code in PR #36187: URL: https://github.com/apache/doris/pull/36187#discussion_r1636303279
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHudiScan.java: ########## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.physical; + +import org.apache.doris.analysis.TableScanParams; +import org.apache.doris.analysis.TableSnapshot; +import org.apache.doris.datasource.ExternalTable; +import org.apache.doris.datasource.hudi.source.IncrementalRelation; +import org.apache.doris.nereids.memo.GroupExpression; +import org.apache.doris.nereids.properties.DistributionSpec; +import org.apache.doris.nereids.properties.LogicalProperties; +import org.apache.doris.nereids.properties.PhysicalProperties; +import org.apache.doris.nereids.trees.TableSample; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.RelationId; +import org.apache.doris.nereids.trees.plans.logical.LogicalFileScan.SelectedPartitions; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.nereids.util.Utils; +import org.apache.doris.statistics.Statistics; + +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +/** + * Physical Hudi scan for Hudi table. + */ +public class PhysicalHudiScan extends PhysicalFileScan { + + // for hudi incremental read + private final Optional<TableScanParams> scanParams; + private final Optional<IncrementalRelation> incrementalRelation; + + /** + * Constructor for PhysicalHudiScan. + */ + public PhysicalHudiScan(RelationId id, ExternalTable table, List<String> qualifier, + DistributionSpec distributionSpec, Optional<GroupExpression> groupExpression, + LogicalProperties logicalProperties, Set<Expression> conjuncts, + SelectedPartitions selectedPartitions, Optional<TableSample> tableSample, + Optional<TableSnapshot> tableSnapshot, + Optional<TableScanParams> scanParams, Optional<IncrementalRelation> incrementalRelation) { + super(id, PlanType.PHYSICAL_HUDI_SCAN, table, qualifier, distributionSpec, groupExpression, logicalProperties, + conjuncts, selectedPartitions, tableSample, tableSnapshot); + Objects.requireNonNull(scanParams, "scanParams should not null"); + Objects.requireNonNull(incrementalRelation, "incrementalRelation should not null"); + this.scanParams = scanParams; + this.incrementalRelation = incrementalRelation; + } + + /** + * Constructor for PhysicalHudiScan. + */ + public PhysicalHudiScan(RelationId id, ExternalTable table, List<String> qualifier, + DistributionSpec distributionSpec, Optional<GroupExpression> groupExpression, + LogicalProperties logicalProperties, PhysicalProperties physicalProperties, + Statistics statistics, Set<Expression> conjuncts, SelectedPartitions selectedPartitions, + Optional<TableSample> tableSample, Optional<TableSnapshot> tableSnapshot, + Optional<TableScanParams> scanParams, Optional<IncrementalRelation> incrementalRelation) { + super(id, PlanType.PHYSICAL_HUDI_SCAN, table, qualifier, distributionSpec, groupExpression, logicalProperties, + physicalProperties, statistics, conjuncts, selectedPartitions, tableSample, tableSnapshot); + this.scanParams = scanParams; + this.incrementalRelation = incrementalRelation; + } + Review Comment: equals and hashCode? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalHudiScan.java: ########## @@ -0,0 +1,226 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.logical; + +import org.apache.doris.analysis.TableScanParams; +import org.apache.doris.analysis.TableSnapshot; +import org.apache.doris.datasource.ExternalTable; +import org.apache.doris.datasource.hive.HMSExternalTable; +import org.apache.doris.datasource.hive.HiveMetaStoreClientHelper; +import org.apache.doris.datasource.hudi.source.COWIncrementalRelation; +import org.apache.doris.datasource.hudi.source.IncrementalRelation; +import org.apache.doris.datasource.hudi.source.MORIncrementalRelation; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.memo.GroupExpression; +import org.apache.doris.nereids.properties.LogicalProperties; +import org.apache.doris.nereids.trees.TableSample; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.StringLiteral; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.RelationId; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.nereids.util.Utils; + +import com.google.common.collect.ImmutableSet; +import com.google.common.collect.Sets; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +/** + * Logical Hudi scan for Hudi table + */ +public class LogicalHudiScan extends LogicalFileScan { + private static final Logger LOG = LogManager.getLogger(LogicalHudiScan.class); + + // for hudi incremental read + private final Optional<TableScanParams> scanParams; + private final Optional<IncrementalRelation> incrementalRelation; + + /** + * Constructor for LogicalHudiScan. + */ + protected LogicalHudiScan(RelationId id, ExternalTable table, List<String> qualifier, + Optional<GroupExpression> groupExpression, Optional<LogicalProperties> logicalProperties, + Set<Expression> conjuncts, SelectedPartitions selectedPartitions, Optional<TableSample> tableSample, + Optional<TableSnapshot> tableSnapshot, + Optional<TableScanParams> scanParams, Optional<IncrementalRelation> incrementalRelation) { + super(id, table, qualifier, groupExpression, logicalProperties, conjuncts, + selectedPartitions, tableSample, tableSnapshot); + Objects.requireNonNull(scanParams, "scanParams should not null"); + Objects.requireNonNull(incrementalRelation, "incrementalRelation should not null"); + this.scanParams = scanParams; + this.incrementalRelation = incrementalRelation; + } + + public LogicalHudiScan(RelationId id, ExternalTable table, List<String> qualifier, + Optional<TableSample> tableSample, Optional<TableSnapshot> tableSnapshot) { + this(id, table, qualifier, Optional.empty(), Optional.empty(), + Sets.newHashSet(), SelectedPartitions.NOT_PRUNED, tableSample, tableSnapshot, + Optional.empty(), Optional.empty()); + } + + public Optional<TableScanParams> getScanParams() { + return scanParams; + } + + public Optional<IncrementalRelation> getIncrementalRelation() { + return incrementalRelation; + } + + /** + * replace incremental params as AND expression + * incr('beginTime'='20240308110257169', 'endTime'='20240308110677278') => + * _hoodie_commit_time >= 20240308110257169 and _hoodie_commit_time <= '20240308110677278' + */ + public Set<Expression> generateIncrementalExpression(List<Slot> slots) { + if (!incrementalRelation.isPresent()) { + return Collections.emptySet(); + } + SlotReference timeField = null; + for (Slot slot : slots) { + if ("_hoodie_commit_time".equals(slot.getName())) { + timeField = (SlotReference) slot; + break; + } + } + if (timeField == null) { + return Collections.emptySet(); + } + StringLiteral upperValue = new StringLiteral(incrementalRelation.get().getEndTs()); + StringLiteral lowerValue = new StringLiteral(incrementalRelation.get().getStartTs()); + ComparisonPredicate less = new LessThanEqual(timeField, upperValue); + ComparisonPredicate great = incrementalRelation.get().isIncludeStartTime() + ? new GreaterThanEqual(timeField, lowerValue) + : new GreaterThan(timeField, lowerValue); + return ImmutableSet.of(great, less); + } + + @Override + public String toString() { + return Utils.toSqlString("LogicalHudiScan", + "qualified", qualifiedName(), + "output", getOutput() + ); + } + + @Override + public LogicalHudiScan withGroupExpression(Optional<GroupExpression> groupExpression) { + return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier, groupExpression, + Optional.of(getLogicalProperties()), conjuncts, selectedPartitions, tableSample, tableSnapshot, + scanParams, incrementalRelation); + } + + @Override + public Plan withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpression, + Optional<LogicalProperties> logicalProperties, List<Plan> children) { + return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier, + groupExpression, logicalProperties, conjuncts, selectedPartitions, tableSample, tableSnapshot, + scanParams, incrementalRelation); + } + + @Override + public LogicalHudiScan withConjuncts(Set<Expression> conjuncts) { + return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier, Optional.empty(), + Optional.of(getLogicalProperties()), conjuncts, selectedPartitions, tableSample, tableSnapshot, + scanParams, incrementalRelation); + } + + public LogicalHudiScan withSelectedPartitions(SelectedPartitions selectedPartitions) { + return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier, Optional.empty(), + Optional.of(getLogicalProperties()), conjuncts, selectedPartitions, tableSample, tableSnapshot, + scanParams, incrementalRelation); + } + + @Override + public LogicalHudiScan withRelationId(RelationId relationId) { + return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier, Optional.empty(), + Optional.empty(), conjuncts, selectedPartitions, tableSample, tableSnapshot, + scanParams, incrementalRelation); + } + + @Override + public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { + return visitor.visitLogicalHudiScan(this, context); + } + + /** Review Comment: equals and hashCode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
