yangzhg commented on a change in pull request #8069:
URL: https://github.com/apache/incubator-doris/pull/8069#discussion_r810444351
##########
File path: be/src/vec/functions/function_cast.h
##########
@@ -374,9 +374,9 @@ struct ToNumberMonotonicity {
Float64 right_float = right.get<Float64>();
if (left_float >= std::numeric_limits<T>::min() &&
- left_float <= std::numeric_limits<T>::max() &&
+ left_float <=
static_cast<Float64>(std::numeric_limits<T>::max()) &&
Review comment:
min is safe to cast to Float64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
