github-actions[bot] commented on code in PR #35900: URL: https://github.com/apache/doris/pull/35900#discussion_r1626924816
########## be/src/pipeline/common/agg_utils.h: ########## @@ -0,0 +1,340 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <variant> +#include <vector> + +#include "vec/common/arena.h" +#include "vec/common/hash_table/hash_map_context.h" +#include "vec/common/hash_table/hash_map_context_creator.h" +#include "vec/common/hash_table/hash_map_util.h" +#include "vec/common/hash_table/ph_hash_map.h" +#include "vec/common/hash_table/string_hash_map.h" + +namespace doris { +namespace pipeline { + +using AggregatedDataWithoutKey = vectorized::AggregateDataPtr; +using AggregatedDataWithStringKey = PHHashMap<StringRef, vectorized::AggregateDataPtr>; +using AggregatedDataWithShortStringKey = StringHashMap<vectorized::AggregateDataPtr>; +using AggregatedDataWithUInt8Key = PHHashMap<vectorized::UInt8, vectorized::AggregateDataPtr>; +using AggregatedDataWithUInt16Key = PHHashMap<vectorized::UInt16, vectorized::AggregateDataPtr>; +using AggregatedDataWithUInt32Key = + PHHashMap<vectorized::UInt32, vectorized::AggregateDataPtr, HashCRC32<vectorized::UInt32>>; +using AggregatedDataWithUInt64Key = + PHHashMap<vectorized::UInt64, vectorized::AggregateDataPtr, HashCRC32<vectorized::UInt64>>; +using AggregatedDataWithUInt128Key = PHHashMap<vectorized::UInt128, vectorized::AggregateDataPtr, + HashCRC32<vectorized::UInt128>>; +using AggregatedDataWithUInt256Key = PHHashMap<vectorized::UInt256, vectorized::AggregateDataPtr, + HashCRC32<vectorized::UInt256>>; +using AggregatedDataWithUInt136Key = PHHashMap<vectorized::UInt136, vectorized::AggregateDataPtr, + HashCRC32<vectorized::UInt136>>; + +using AggregatedDataWithUInt32KeyPhase2 = + PHHashMap<vectorized::UInt32, vectorized::AggregateDataPtr, + HashMixWrapper<vectorized::UInt32>>; +using AggregatedDataWithUInt64KeyPhase2 = + PHHashMap<vectorized::UInt64, vectorized::AggregateDataPtr, + HashMixWrapper<vectorized::UInt64>>; +using AggregatedDataWithUInt128KeyPhase2 = + PHHashMap<vectorized::UInt128, vectorized::AggregateDataPtr, + HashMixWrapper<vectorized::UInt128>>; +using AggregatedDataWithUInt256KeyPhase2 = + PHHashMap<vectorized::UInt256, vectorized::AggregateDataPtr, + HashMixWrapper<vectorized::UInt256>>; + +using AggregatedDataWithUInt136KeyPhase2 = + PHHashMap<vectorized::UInt136, vectorized::AggregateDataPtr, + HashMixWrapper<vectorized::UInt136>>; + +using AggregatedDataWithNullableUInt8Key = vectorized::DataWithNullKey<AggregatedDataWithUInt8Key>; +using AggregatedDataWithNullableUInt16Key = + vectorized::DataWithNullKey<AggregatedDataWithUInt16Key>; +using AggregatedDataWithNullableUInt32Key = + vectorized::DataWithNullKey<AggregatedDataWithUInt32Key>; +using AggregatedDataWithNullableUInt64Key = + vectorized::DataWithNullKey<AggregatedDataWithUInt64Key>; +using AggregatedDataWithNullableUInt32KeyPhase2 = + vectorized::DataWithNullKey<AggregatedDataWithUInt32KeyPhase2>; +using AggregatedDataWithNullableUInt64KeyPhase2 = + vectorized::DataWithNullKey<AggregatedDataWithUInt64KeyPhase2>; +using AggregatedDataWithNullableShortStringKey = + vectorized::DataWithNullKey<AggregatedDataWithShortStringKey>; +using AggregatedDataWithNullableUInt128Key = + vectorized::DataWithNullKey<AggregatedDataWithUInt128Key>; +using AggregatedDataWithNullableUInt128KeyPhase2 = + vectorized::DataWithNullKey<AggregatedDataWithUInt128KeyPhase2>; + +using AggregatedMethodVariants = std::variant< + std::monostate, vectorized::MethodSerialized<AggregatedDataWithStringKey>, + vectorized::MethodOneNumber<vectorized::UInt8, AggregatedDataWithUInt8Key>, + vectorized::MethodOneNumber<vectorized::UInt16, AggregatedDataWithUInt16Key>, + vectorized::MethodOneNumber<vectorized::UInt32, AggregatedDataWithUInt32Key>, + vectorized::MethodOneNumber<vectorized::UInt64, AggregatedDataWithUInt64Key>, + vectorized::MethodStringNoCache<AggregatedDataWithShortStringKey>, + vectorized::MethodOneNumber<vectorized::UInt128, AggregatedDataWithUInt128Key>, + vectorized::MethodOneNumber<vectorized::UInt32, AggregatedDataWithUInt32KeyPhase2>, + vectorized::MethodOneNumber<vectorized::UInt64, AggregatedDataWithUInt64KeyPhase2>, + vectorized::MethodOneNumber<vectorized::UInt128, AggregatedDataWithUInt128KeyPhase2>, + vectorized::MethodSingleNullableColumn< + vectorized::MethodOneNumber<vectorized::UInt8, AggregatedDataWithNullableUInt8Key>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt16, AggregatedDataWithNullableUInt16Key>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt32, AggregatedDataWithNullableUInt32Key>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt64, AggregatedDataWithNullableUInt64Key>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt32, AggregatedDataWithNullableUInt32KeyPhase2>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt64, AggregatedDataWithNullableUInt64KeyPhase2>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt128, AggregatedDataWithNullableUInt128Key>>, + vectorized::MethodSingleNullableColumn<vectorized::MethodOneNumber< + vectorized::UInt128, AggregatedDataWithNullableUInt128KeyPhase2>>, + vectorized::MethodSingleNullableColumn< + vectorized::MethodStringNoCache<AggregatedDataWithNullableShortStringKey>>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt64Key, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt64Key, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt128Key, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt128Key, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt256Key, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt256Key, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt136Key, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt136Key, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt64KeyPhase2, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt64KeyPhase2, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt128KeyPhase2, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt128KeyPhase2, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt256KeyPhase2, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt256KeyPhase2, true>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt136KeyPhase2, false>, + vectorized::MethodKeysFixed<AggregatedDataWithUInt136KeyPhase2, true>>; + +struct AggregatedDataVariants + : public vectorized::DataVariants<AggregatedMethodVariants, + vectorized::MethodSingleNullableColumn, + vectorized::MethodOneNumber, vectorized::MethodKeysFixed, + vectorized::DataWithNullKey> { + AggregatedDataWithoutKey without_key = nullptr; + + template <bool nullable> + void init(Type type) { + _type = type; + switch (_type) { + case Type::without_key: + break; + case Type::serialized: + method_variant.emplace<vectorized::MethodSerialized<AggregatedDataWithStringKey>>(); + break; + case Type::int8_key: + emplace_single<vectorized::UInt8, AggregatedDataWithUInt8Key, nullable>(); + break; + case Type::int16_key: + emplace_single<vectorized::UInt16, AggregatedDataWithUInt16Key, nullable>(); + break; + case Type::int32_key: + emplace_single<vectorized::UInt32, AggregatedDataWithUInt32Key, nullable>(); + break; + case Type::int32_key_phase2: + emplace_single<vectorized::UInt32, AggregatedDataWithUInt32KeyPhase2, nullable>(); + break; + case Type::int64_key: + emplace_single<vectorized::UInt64, AggregatedDataWithUInt64Key, nullable>(); + break; + case Type::int64_key_phase2: + emplace_single<vectorized::UInt64, AggregatedDataWithUInt64KeyPhase2, nullable>(); + break; + case Type::int128_key: + emplace_single<vectorized::UInt128, AggregatedDataWithUInt128Key, nullable>(); + break; + case Type::int128_key_phase2: + emplace_single<vectorized::UInt128, AggregatedDataWithUInt128KeyPhase2, nullable>(); + break; + case Type::string_key: + if (nullable) { + method_variant.emplace< + vectorized::MethodSingleNullableColumn<vectorized::MethodStringNoCache< + AggregatedDataWithNullableShortStringKey>>>(); + } else { + method_variant.emplace< + vectorized::MethodStringNoCache<AggregatedDataWithShortStringKey>>(); + } + break; + default: + throw Exception(ErrorCode::INTERNAL_ERROR, "meet invalid key type, type={}", type); + } + } + + void init(Type type, bool is_nullable = false) { + if (is_nullable) { + init<true>(type); + } else { + init<false>(type); + } + } +}; + +using AggregatedDataVariantsUPtr = std::unique_ptr<AggregatedDataVariants>; +using ArenaUPtr = std::unique_ptr<vectorized::Arena>; + +struct AggregateDataContainer { +public: + AggregateDataContainer(size_t size_of_key, size_t size_of_aggregate_states) + : _size_of_key(size_of_key), _size_of_aggregate_states(size_of_aggregate_states) {} + + int64_t memory_usage() const { return _arena_pool.size(); } + + template <typename KeyType> + vectorized::AggregateDataPtr append_data(const KeyType& key) { + DCHECK_EQ(sizeof(KeyType), _size_of_key); + // SUB_CONTAINER_CAPACITY should add a new sub container, and also expand when it is zero + if (UNLIKELY(_index_in_sub_container % SUB_CONTAINER_CAPACITY == 0)) { + _expand(); + } + + *reinterpret_cast<KeyType*>(_current_keys) = key; + auto aggregate_data = _current_agg_data; Review Comment: warning: 'auto aggregate_data' can be declared as 'auto *aggregate_data' [readability-qualified-auto] ```suggestion auto *aggregate_data = _current_agg_data; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
