HappenLee commented on code in PR #35628:
URL: https://github.com/apache/doris/pull/35628#discussion_r1625933395
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -708,6 +719,79 @@ Status ColumnReader::new_iterator(ColumnIterator**
iterator) {
}
}
+Status ColumnReader::new_agg_state_iterator(ColumnIterator** iterator) {
+ if (!_agg_state_ptr) { // meet old version ColumnMetaPB
+ *iterator = new FileColumnIterator(this);
+ return Status::OK();
+ }
+
+ const auto* agg_state_type =
+ assert_cast<const
vectorized::DataTypeAggState*>(_agg_state_ptr.get());
+ auto type =
agg_state_type->get_serialized_type()->get_type_as_type_descriptor().type;
+
+ if (type == PrimitiveType::TYPE_STRING || type ==
PrimitiveType::INVALID_TYPE ||
Review Comment:
```type == PrimitiveType::TYPE_STRING || type == PrimitiveType::INVALID_TYPE
||
type == PrimitiveType::TYPE_OBJECT``` better be a function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
