BiteTheDDDDt commented on a change in pull request #8066: URL: https://github.com/apache/incubator-doris/pull/8066#discussion_r806768158
########## File path: be/src/vec/aggregate_functions/aggregate_function_percentile_approx.h ########## @@ -0,0 +1,250 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "common/status.h" +#include "util/counts.h" +#include "util/tdigest.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/columns/columns_number.h" +#include "vec/data_types/data_type_decimal.h" +#include "vec/data_types/data_type_number.h" +#include "vec/io/io_helper.h" +namespace doris::vectorized { + +struct PercentileApproxState { + static constexpr double INIT_QUANTILE = -1.0; + PercentileApproxState() {} + ~PercentileApproxState() {} + + void init(double compression = 10000) { + if (!init_flag) { + digest.reset(new TDigest(compression)); + init_flag = true; + } + } + + void write(BufferWritable& buf) const { + write_binary(init_flag, buf); + write_binary(targetQuantile, buf); + + uint32_t serialize_size = digest->serialized_size(); + std::string result(serialize_size, '0'); + DCHECK(digest.get() != nullptr); + digest->serialize((uint8_t*)result.c_str()); + + write_binary(result, buf); + } + void read(BufferReadable& buf) { + read_binary(init_flag, buf); + read_binary(targetQuantile, buf); + + std::string str; + read_binary(str, buf); + digest.reset(new TDigest()); + digest->unserialize((uint8_t*)str.c_str()); + } + + double get() const { return digest->quantile(targetQuantile); } + + void merge(const PercentileApproxState& rhs) { + if (init_flag) { + DCHECK(digest.get() != nullptr); + digest->merge(rhs.digest.get()); + } else { + digest.reset(new TDigest()); Review comment: here should update inif_flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
