zuochunwei commented on a change in pull request #7972:
URL: https://github.com/apache/incubator-doris/pull/7972#discussion_r805648869
##########
File path: be/src/vec/exec/join/join_op.h
##########
@@ -26,15 +26,15 @@ namespace doris::vectorized {
struct RowRef {
using SizeT = uint32_t; /// Do not use size_t cause of memory economy
- const Block* block = nullptr;
+ // const Block* block = nullptr;
SizeT row_num = 0;
// Use in right join to mark row is visited
// TODO: opt the varaible to use it only need
bool visited = false;
RowRef() {}
- RowRef(const Block* block_ptr, size_t row_num_count, bool is_visited =
false)
- : block(block_ptr), row_num(row_num_count), visited(is_visited) {}
Review comment:
i am not sure whether placing member data 'row_count' before 'next' will
save memory, try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
