seawinde commented on code in PR #35562:
URL: https://github.com/apache/doris/pull/35562#discussion_r1621596354


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Interval.java:
##########
@@ -61,30 +63,51 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C 
context) {
      * Supported time unit.
      */
     public enum TimeUnit {
-        YEAR("YEAR", false),
-        MONTH("MONTH", false),
-        WEEK("WEEK", false),
-        DAY("DAY", false),
-        HOUR("HOUR", true),
-        MINUTE("MINUTE", true),
-        SECOND("SECOND", true);
+        YEAR("YEAR", false, 800),

Review Comment:
   Maybe will add new time unit in the future, maybe 100-800 keep the 
extensibility in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to