This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit fd23386ec5475dfe0c5de5b7811b66d7108053b4
Author: slothever <[email protected]>
AuthorDate: Thu May 30 18:29:00 2024 +0800

    [fix](auth)fix simple auth check and default username (#35620)
    
    fix simple auth check and default username
    we should set simple auth to valid by default, and check whether to set
    the default username in loginWithUGI
---
 .../org/apache/doris/common/security/authentication/HadoopUGI.java     | 1 +
 .../common/security/authentication/SimpleAuthenticationConfig.java     | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java
 
b/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java
index 43c19fb1a3f..342f86b7125 100644
--- 
a/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java
+++ 
b/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java
@@ -73,6 +73,7 @@ public class HadoopUGI {
             String hadoopUserName = ((SimpleAuthenticationConfig) 
config).getUsername();
             if (hadoopUserName == null) {
                 hadoopUserName = "hadoop";
+                ((SimpleAuthenticationConfig) 
config).setUsername(hadoopUserName);
                 LOG.debug(AuthenticationConfig.HADOOP_USER_NAME + " is unset, 
use default user: hadoop");
             }
             ugi = UserGroupInformation.createRemoteUser(hadoopUserName);
diff --git 
a/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java
 
b/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java
index 57bb7887372..d202417afc8 100644
--- 
a/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java
+++ 
b/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java
@@ -18,7 +18,6 @@
 package org.apache.doris.common.security.authentication;
 
 import lombok.Data;
-import org.apache.commons.lang3.StringUtils;
 
 @Data
 public class SimpleAuthenticationConfig extends AuthenticationConfig {
@@ -26,6 +25,6 @@ public class SimpleAuthenticationConfig extends 
AuthenticationConfig {
 
     @Override
     public boolean isValid() {
-        return StringUtils.isNotEmpty(username);
+        return true;
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to