yiguolei commented on code in PR #35560:
URL: https://github.com/apache/doris/pull/35560#discussion_r1618080749
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -120,6 +120,7 @@ Status PipelineTask::prepare(const TPipelineInstanceParams&
local_params, const
}
Status PipelineTask::_extract_dependencies() {
+ std::unique_lock<std::mutex> lc(_dependency_lock);
Review Comment:
不要这么写。
这么写会让这个lock的范围扩大到了local state 或者operator 的具体操作中，容易有死锁之类的问题。
这个dependency lock 只应该限制对 PipelineTask 内部这几个数据结构的操作。
比如，你可以先把这些extract的depdency 放到一个临时变量里，然后再加lock，修改pipeline task 中的
_read_dependencies 结构。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
