HappenLee commented on a change in pull request #7979:
URL: https://github.com/apache/incubator-doris/pull/7979#discussion_r801306092
##########
File path: be/src/exec/data_sink.cpp
##########
@@ -38,7 +38,7 @@
#include "vec/sink/result_sink.h"
#include "vec/sink/vdata_stream_sender.h"
#include "vec/sink/vtablet_sink.h"
-
+#include "vec/sink/vmysql_table_writer.h"
namespace doris {
Review comment:
add space
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
+
+ if (i != 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", ", ");
+ }
+
+ vectorized::ColumnPtr column;
+ if (type_ptr->is_nullable()) {
+ column = assert_cast<const
vectorized::ColumnNullable&>(*column_ptr)
+ .get_nested_column_ptr();
+ if (column_ptr->is_null_at(row)) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ continue;
+ }
+ } else {
+ column = column_ptr;
+ }
+
+ switch (_vec_output_expr_ctxs[i]->root()->result_type()) {
+ case TYPE_BOOLEAN: {
+ auto& data = assert_cast<const
vectorized::ColumnUInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
Review comment:
do not call to_string
##########
File path: be/src/vec/sink/vmysql_table_writer.cpp
##########
@@ -0,0 +1,91 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <sstream>
+
+#include "exprs/expr.h"
+#include "runtime/mem_tracker.h"
+#include "runtime/mysql_table_sink.h"
+#include "runtime/runtime_state.h"
+#include "util/debug_util.h"
+#include "util/runtime_profile.h"
+#include "vec/sink/vmysql_table_writer.h"
+#include "vec/exprs/vexpr.h"
+
+namespace doris {
+namespace vectorized {
+VMysqlTableSink::VMysqlTableSink(ObjectPool* pool, const RowDescriptor&
row_desc,
+ const std::vector<TExpr>& t_exprs)
+ : _pool(pool),
+ _row_desc(row_desc),
+ _t_output_expr(t_exprs),
+ _mem_tracker(MemTracker::CreateTracker(-1, "VMysqlTableSink")) {
+ _name = "VMysqlTableSink";
+}
+
+VMysqlTableSink::~VMysqlTableSink() {}
+
+Status VMysqlTableSink::init(const TDataSink& t_sink) {
+ RETURN_IF_ERROR(DataSink::init(t_sink));
+ const TMysqlTableSink& t_mysql_sink = t_sink.mysql_table_sink;
+
+ _conn_info.host = t_mysql_sink.host;
+ _conn_info.port = t_mysql_sink.port;
+ _conn_info.user = t_mysql_sink.user;
+ _conn_info.passwd = t_mysql_sink.passwd;
+ _conn_info.db = t_mysql_sink.db;
+ _mysql_tbl = t_mysql_sink.table;
+
+ // From the thrift expressions create the real exprs.
+ RETURN_IF_ERROR(VExpr::create_expr_trees(_pool, _t_output_expr,
&_output_expr_ctxs));
+ return Status::OK();
+}
+
+Status VMysqlTableSink::prepare(RuntimeState* state) {
+ RETURN_IF_ERROR(DataSink::prepare(state));
+ // Prepare the exprs to run.
+ RETURN_IF_ERROR(VExpr::prepare(_output_expr_ctxs, state, _row_desc,
_mem_tracker));
+ std::stringstream title;
Review comment:
use format to replace stringstream
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
Review comment:
do convert before call `insert_row`
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
Review comment:
do not copy
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
+
+ if (i != 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", ", ");
+ }
+
+ vectorized::ColumnPtr column;
+ if (type_ptr->is_nullable()) {
+ column = assert_cast<const
vectorized::ColumnNullable&>(*column_ptr)
+ .get_nested_column_ptr();
+ if (column_ptr->is_null_at(row)) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ continue;
+ }
+ } else {
+ column = column_ptr;
+ }
+
+ switch (_vec_output_expr_ctxs[i]->root()->result_type()) {
+ case TYPE_BOOLEAN: {
+ auto& data = assert_cast<const
vectorized::ColumnUInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_TINYINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_SMALLINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt16&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_INT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_BIGINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_FLOAT: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_DOUBLE: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+
+ case TYPE_STRING:
+ case TYPE_CHAR:
+ case TYPE_VARCHAR: {
+ const auto& string_val =
+ assert_cast<const
vectorized::ColumnString&>(*column).get_data_at(row);
+ if (string_val.data == nullptr) {
Review comment:
DCHECK not nullptr
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
+
+ if (i != 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", ", ");
+ }
+
+ vectorized::ColumnPtr column;
+ if (type_ptr->is_nullable()) {
+ column = assert_cast<const
vectorized::ColumnNullable&>(*column_ptr)
+ .get_nested_column_ptr();
+ if (column_ptr->is_null_at(row)) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ continue;
+ }
+ } else {
+ column = column_ptr;
+ }
+
+ switch (_vec_output_expr_ctxs[i]->root()->result_type()) {
+ case TYPE_BOOLEAN: {
+ auto& data = assert_cast<const
vectorized::ColumnUInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_TINYINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_SMALLINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt16&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_INT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_BIGINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_FLOAT: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_DOUBLE: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+
+ case TYPE_STRING:
+ case TYPE_CHAR:
+ case TYPE_VARCHAR: {
+ const auto& string_val =
+ assert_cast<const
vectorized::ColumnString&>(*column).get_data_at(row);
+ if (string_val.data == nullptr) {
+ if (string_val.size == 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "''");
+ } else {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ }
+ } else {
+ char* buf = new char[2 * string_val.size + 1];
+ mysql_real_escape_string(_mysql_conn, buf, string_val.data,
string_val.size);
+ fmt::format_to(_insert_stmt_buffer, "'{}'", buf);
+ delete[] buf;
+ }
+ break;
+ }
+ case TYPE_DECIMALV2: {
+ DecimalV2Value value =
+ (DecimalV2Value)
+ assert_cast<const
vectorized::ColumnDecimal<vectorized::Decimal128>&>(
+ *column)
+ .get_data()[row];
+ fmt::format_to(_insert_stmt_buffer, "{}", value.to_string());
+ break;
+ }
+ case TYPE_DATE:
+ case TYPE_DATETIME: {
+ int64_t int_val = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data()[row];
+ vectorized::VecDateTimeValue value =
+ binary_cast<int64_t,
doris::vectorized::VecDateTimeValue>(int_val);
+
+ char buf[64];
+ char* pos = value.to_string(buf);
+ std::string str(buf, pos - buf - 1);
+ fmt::format_to(_insert_stmt_buffer, "'{}'", str);
+ break;
+ }
+ default: {
+ fmt::memory_buffer err_out;
+ fmt::format_to(err_out, "can't convert this type to mysql type.
type = {}",
+ _vec_output_expr_ctxs[i]->root()->type().type);
+ return Status::InternalError(err_out.data());
+ }
+ }
+ }
+
+ fmt::format_to(_insert_stmt_buffer, "{}", ")");
+
+ // Insert this to MySQL server
+ std::string insert_stmt = to_string(_insert_stmt_buffer);
+ LOG(INFO) << insert_stmt;
Review comment:
do not log each insert query
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
+
+ if (i != 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", ", ");
+ }
+
+ vectorized::ColumnPtr column;
+ if (type_ptr->is_nullable()) {
+ column = assert_cast<const
vectorized::ColumnNullable&>(*column_ptr)
+ .get_nested_column_ptr();
+ if (column_ptr->is_null_at(row)) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ continue;
+ }
+ } else {
+ column = column_ptr;
+ }
+
+ switch (_vec_output_expr_ctxs[i]->root()->result_type()) {
+ case TYPE_BOOLEAN: {
+ auto& data = assert_cast<const
vectorized::ColumnUInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_TINYINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_SMALLINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt16&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_INT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_BIGINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_FLOAT: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_DOUBLE: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+
+ case TYPE_STRING:
+ case TYPE_CHAR:
+ case TYPE_VARCHAR: {
+ const auto& string_val =
+ assert_cast<const
vectorized::ColumnString&>(*column).get_data_at(row);
+ if (string_val.data == nullptr) {
+ if (string_val.size == 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "''");
+ } else {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ }
+ } else {
+ char* buf = new char[2 * string_val.size + 1];
Review comment:
unique_ptr
##########
File path: be/src/runtime/mysql_table_writer.cpp
##########
@@ -182,4 +190,150 @@ Status MysqlTableWriter::append(RowBatch* batch) {
return Status::OK();
}
+Status MysqlTableWriter::append(vectorized::Block* block) {
+ Status status = Status::OK();
+ if (block == nullptr || block->rows() == 0) {
+ return status;
+ }
+
+ auto output_block =
vectorized::VExprContext::get_output_block_after_execute_exprs(
+ _vec_output_expr_ctxs, *block, status);
+
+ auto num_rows = output_block.rows();
+ if (UNLIKELY(num_rows == 0)) {
+ return status;
+ }
+
+ for (int i = 0; i < num_rows; ++i) {
+ RETURN_IF_ERROR(insert_row(output_block, i));
+ }
+ return Status::OK();
+}
+
+Status MysqlTableWriter::insert_row(vectorized::Block& block, size_t row) {
+ _insert_stmt_buffer.clear();
+ fmt::format_to(_insert_stmt_buffer, "INSERT INTO {} VALUES (", _mysql_tbl);
+ int num_columns = _vec_output_expr_ctxs.size();
+
+ for (int i = 0; i < num_columns; ++i) {
+ auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ auto type_ptr = block.get_by_position(i).type;
+
+ if (i != 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", ", ");
+ }
+
+ vectorized::ColumnPtr column;
+ if (type_ptr->is_nullable()) {
+ column = assert_cast<const
vectorized::ColumnNullable&>(*column_ptr)
+ .get_nested_column_ptr();
+ if (column_ptr->is_null_at(row)) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ continue;
+ }
+ } else {
+ column = column_ptr;
+ }
+
+ switch (_vec_output_expr_ctxs[i]->root()->result_type()) {
+ case TYPE_BOOLEAN: {
+ auto& data = assert_cast<const
vectorized::ColumnUInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_TINYINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt8&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_SMALLINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt16&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_INT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_BIGINT: {
+ auto& data = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_FLOAT: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat32&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+ case TYPE_DOUBLE: {
+ auto& data = assert_cast<const
vectorized::ColumnFloat64&>(*column).get_data();
+ fmt::format_to(_insert_stmt_buffer, "{}",
std::to_string(data[row]));
+ break;
+ }
+
+ case TYPE_STRING:
+ case TYPE_CHAR:
+ case TYPE_VARCHAR: {
+ const auto& string_val =
+ assert_cast<const
vectorized::ColumnString&>(*column).get_data_at(row);
+ if (string_val.data == nullptr) {
+ if (string_val.size == 0) {
+ fmt::format_to(_insert_stmt_buffer, "{}", "''");
+ } else {
+ fmt::format_to(_insert_stmt_buffer, "{}", "NULL");
+ }
+ } else {
+ char* buf = new char[2 * string_val.size + 1];
+ mysql_real_escape_string(_mysql_conn, buf, string_val.data,
string_val.size);
+ fmt::format_to(_insert_stmt_buffer, "'{}'", buf);
+ delete[] buf;
+ }
+ break;
+ }
+ case TYPE_DECIMALV2: {
+ DecimalV2Value value =
+ (DecimalV2Value)
+ assert_cast<const
vectorized::ColumnDecimal<vectorized::Decimal128>&>(
+ *column)
+ .get_data()[row];
+ fmt::format_to(_insert_stmt_buffer, "{}", value.to_string());
+ break;
+ }
+ case TYPE_DATE:
+ case TYPE_DATETIME: {
+ int64_t int_val = assert_cast<const
vectorized::ColumnInt64&>(*column).get_data()[row];
+ vectorized::VecDateTimeValue value =
+ binary_cast<int64_t,
doris::vectorized::VecDateTimeValue>(int_val);
+
+ char buf[64];
+ char* pos = value.to_string(buf);
+ std::string str(buf, pos - buf - 1);
+ fmt::format_to(_insert_stmt_buffer, "'{}'", str);
+ break;
+ }
+ default: {
+ fmt::memory_buffer err_out;
+ fmt::format_to(err_out, "can't convert this type to mysql type.
type = {}",
+ _vec_output_expr_ctxs[i]->root()->type().type);
+ return Status::InternalError(err_out.data());
+ }
+ }
+ }
+
+ fmt::format_to(_insert_stmt_buffer, "{}", ")");
+
+ // Insert this to MySQL server
+ std::string insert_stmt = to_string(_insert_stmt_buffer);
Review comment:
try to reduce the mem alloc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
