yiguolei commented on code in PR #35432:
URL: https://github.com/apache/doris/pull/35432#discussion_r1615569048
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -388,11 +394,7 @@ bool
BetaRowsetReader::_should_push_down_value_predicates() const {
}
Status BetaRowsetReader::get_segment_num_rows(std::vector<uint32_t>*
segment_num_rows) {
- auto& seg_ptrs = _segment_cache_handle.get_segments();
- segment_num_rows->resize(seg_ptrs.size());
- for (size_t i = 0; i < seg_ptrs.size(); i++) {
- (*segment_num_rows)[i] = seg_ptrs[i]->num_rows();
- }
+ segment_num_rows->assign(_segments_rows.cbegin(), _segments_rows.cend());
Review Comment:
could you make sure that this method is called after get_segment_iterators???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
