morningman commented on a change in pull request #7828:
URL: https://github.com/apache/incubator-doris/pull/7828#discussion_r798466767
##########
File path: be/src/vec/data_types/data_type_bitmap.h
##########
@@ -83,6 +84,9 @@ struct is_complex : std::false_type {};
template <>
struct is_complex<DataTypeBitMap::FieldType> : std::true_type {};
+template <>
+struct is_complex<DataTypeHLL::FieldType> : std::true_type {};
Review comment:
Why define HLL in `data_type_bitmap`?
##########
File path: be/src/vec/data_types/data_type_hll.cpp
##########
@@ -0,0 +1,103 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "vec/data_types/data_type_hll.h"
+
+#include "vec/columns/column_complex.h"
+#include "vec/common/assert_cast.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+size_t DataTypeHLL::serialize(const IColumn& column, PColumn* pcolumn) const {
Review comment:
The serialize() method has been refactored in #7939 , please change it
after that PR being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
