924060929 commented on a change in pull request #7645:
URL: https://github.com/apache/incubator-doris/pull/7645#discussion_r794276864
##########
File path: be/src/exprs/runtime_filter.cpp
##########
@@ -439,9 +481,20 @@ class RuntimePredicateWrapper {
}
Status merge(const RuntimePredicateWrapper* wrapper) {
- DCHECK(_filter_type == wrapper->_filter_type);
- if (_filter_type != wrapper->_filter_type) {
- return Status::InvalidArgument("invalid filter type");
+ bool can_not_merge_in_or_bloom
+ = _filter_type == RuntimeFilterType::IN_OR_BLOOM_FILTER &&
+ (wrapper->_filter_type != RuntimeFilterType::IN_FILTER
+ && wrapper->_filter_type !=
RuntimeFilterType::BLOOM_FILTER);
+
+ bool can_not_merge_other = _filter_type !=
RuntimeFilterType::IN_OR_BLOOM_FILTER
+ && _filter_type != wrapper->_filter_type;
+
+ if (can_not_merge_in_or_bloom || can_not_merge_other) {
+ std::stringstream msg;
Review comment:
already change to CHECK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
