morningman commented on a change in pull request #7391:
URL: https://github.com/apache/incubator-doris/pull/7391#discussion_r792333809
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -2631,7 +2636,15 @@ public Frontend getFeByName(String name) {
public void createDb(CreateDbStmt stmt) throws DdlException {
final String clusterName = stmt.getClusterName();
String fullDbName = stmt.getFullDbName();
- long id = 0L;
+ Map<String, String> properties = stmt.getProperties();
+
+ long id = getNextId();
+ Database db = new Database(id, fullDbName);
+ db.setClusterName(clusterName);
+ // check and analyze database properties before create database
+ db.getDbProperties().putAll(properties);
Review comment:
merge these 2 methods:
```
db.getDbProperties().putAll(properties);
db.getDbProperties().checkAndBuildProperties();
```
to
```
db.addAndBuildProperties(properties);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
