wangbo commented on a change in pull request #7892:
URL: https://github.com/apache/incubator-doris/pull/7892#discussion_r792307629
##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp
##########
@@ -266,8 +267,9 @@ Status BinaryDictPageDecoder::next_batch(size_t* n,
vectorized::MutableColumnPtr
// fill null bitmap here, not null;
// todo(wb) using SIMD speed up here
+ auto& null_map_data = nullable_column->get_null_map_data();
for (int i = 0; i < max_fetch; i++) {
- nullable_column->get_null_map_data().push_back(0);
+ null_map_data.push_back(0);
Review comment:
the TODO batch insert has been solved by #7836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
