morningman commented on a change in pull request #7883:
URL: https://github.com/apache/incubator-doris/pull/7883#discussion_r791683698



##########
File path: be/CMakeLists.txt
##########
@@ -350,6 +350,11 @@ if (COMPILER_GCC)
 endif ()
 
 if (COMPILER_CLANG)
+
+    if(MAKE_TEST STREQUAL "OFF")
+        add_compile_options(-Qunused-arguments)

Review comment:
       Why adding this? Add comment to explain

##########
File path: be/CMakeLists.txt
##########
@@ -350,6 +350,11 @@ if (COMPILER_GCC)
 endif ()
 
 if (COMPILER_CLANG)
+
+    if(MAKE_TEST STREQUAL "OFF")
+        add_compile_options(-Qunused-arguments)

Review comment:
       Why adding this? Add comment to explain




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to