morningman commented on a change in pull request #7884: URL: https://github.com/apache/incubator-doris/pull/7884#discussion_r791375122
########## File path: be/src/vec/columns/column_string.cpp ########## @@ -292,6 +292,7 @@ ColumnPtr ColumnString::replicate(const Offsets& replicate_offsets) const { void ColumnString::reserve(size_t n) { offsets.reserve(n); + chars.reserve(n * 5); Review comment: why multi 5? add comment to explain, or define it as a variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org