This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 73419c243116300511f76d1964f7373d540c0673
Author: zhangdong <493738...@qq.com>
AuthorDate: Fri May 17 10:55:10 2024 +0800

    [enhance](mtmv)MTMV support hive table determine whether the data is sync 
(#34845)
    
    Previously supported, this PR only turns on the switch
---
 .../java/org/apache/doris/datasource/hive/HMSExternalTable.java   | 2 +-
 regression-test/suites/mtmv_p0/test_hive_mtmv.groovy              | 8 --------
 regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy      | 8 ++++----
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java
 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java
index c2099a1acc8..57dee5debb0 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java
@@ -958,7 +958,7 @@ public class HMSExternalTable extends ExternalTable 
implements MTMVRelatedTableI
 
     @Override
     public boolean needAutoRefresh() {
-        return false;
+        return true;
     }
 
     @Override
diff --git a/regression-test/suites/mtmv_p0/test_hive_mtmv.groovy 
b/regression-test/suites/mtmv_p0/test_hive_mtmv.groovy
index 8a91a45c5f8..872d7bf8ec0 100644
--- a/regression-test/suites/mtmv_p0/test_hive_mtmv.groovy
+++ b/regression-test/suites/mtmv_p0/test_hive_mtmv.groovy
@@ -61,14 +61,6 @@ suite("test_hive_mtmv", 
"p0,external,hive,external_docker,external_docker_hive")
             waitingMTMVTaskFinished(jobName)
             order_qt_refresh_one_partition "SELECT * FROM ${mvName} order by 
id"
 
-            //refresh other partitions
-            // current, for hive, auto refresh will not change data
-            sql """
-                    REFRESH MATERIALIZED VIEW ${mvName} AUTO
-                """
-            waitingMTMVTaskFinished(jobName)
-            order_qt_refresh_other_partition "SELECT * FROM ${mvName} order by 
id"
-
             //refresh complete
             sql """
                     REFRESH MATERIALIZED VIEW ${mvName} complete
diff --git a/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy 
b/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy
index 755c6c15b0d..ac19ecc0605 100644
--- a/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy
+++ b/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy
@@ -95,7 +95,7 @@ suite("test_hive_refresh_mtmv", 
"p0,external,hive,external_docker,external_docke
         assertTrue(showPartitionsResult.toString().contains("p_2020"))
 
         sql """
-                REFRESH MATERIALIZED VIEW ${mvName} complete
+                REFRESH MATERIALIZED VIEW ${mvName} auto
             """
         def jobName = getJobName(dbName, mvName);
         waitingMTMVTaskFinished(jobName)
@@ -108,7 +108,7 @@ suite("test_hive_refresh_mtmv", 
"p0,external,hive,external_docker,external_docke
                 REFRESH catalog ${catalog_name}
             """
         sql """
-            REFRESH MATERIALIZED VIEW ${mvName} complete
+            REFRESH MATERIALIZED VIEW ${mvName} auto
         """
         waitingMTMVTaskFinished(jobName)
         order_qt_mtmv_2 "SELECT * FROM ${mvName} order by user_id"
@@ -124,7 +124,7 @@ suite("test_hive_refresh_mtmv", 
"p0,external,hive,external_docker,external_docke
                 REFRESH catalog ${catalog_name}
             """
         sql """
-            REFRESH MATERIALIZED VIEW ${mvName} complete
+            REFRESH MATERIALIZED VIEW ${mvName} auto
         """
         waitingMTMVTaskFinished(jobName)
         showPartitionsResult = sql """show partitions from ${mvName}"""
@@ -143,7 +143,7 @@ suite("test_hive_refresh_mtmv", 
"p0,external,hive,external_docker,external_docke
                 REFRESH catalog ${catalog_name}
             """
             sql """
-                REFRESH MATERIALIZED VIEW ${mvName} complete
+                REFRESH MATERIALIZED VIEW ${mvName} auto
             """
             waitingMTMVTaskFinished(jobName)
             showPartitionsResult = sql """show partitions from ${mvName}"""


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to