yiguolei commented on code in PR #34985:
URL: https://github.com/apache/doris/pull/34985#discussion_r1605696566
##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -164,16 +172,35 @@ inline bool
ThreadMemTrackerMgr::push_consumer_tracker(MemTracker* tracker) {
}
_consumer_tracker_stack.push_back(tracker);
tracker->release(_untracked_mem);
+ tracker->consume(_reserved_mem); // consume in advance
return true;
}
inline void ThreadMemTrackerMgr::pop_consumer_tracker() {
DCHECK(!_consumer_tracker_stack.empty());
_consumer_tracker_stack.back()->consume(_untracked_mem);
+ _consumer_tracker_stack.back()->release(_reserved_mem);
_consumer_tracker_stack.pop_back();
}
inline void ThreadMemTrackerMgr::consume(int64_t size, int
skip_large_memory_check) {
+ if (_reserved_mem != 0) {
+ if (_reserved_mem >= size) {
Review Comment:
这里要加注释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
